gitadmin/ArchiTools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: hooks order violation in DeadlineResolveDialog causing crash

Browse Source 
useMemo was called after early return (when deadline=null), violating
React Rules of Hooks. Moved all hooks before the conditional return.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
AI Assistant
2026-03-11 00:30:38 +02:00
parent 959590acfe
commit 7094114c36
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/registratura/components/deadline-resolve-dialog.tsx
+3 -3
View File
@@ -30,9 +30,7 @@ export function DeadlineResolveDialog({ open, deadline, onOpenChange, onResolve
const [resolution, setResolution] = useState<DeadlineResolution>('completed'); const [resolution, setResolution] = useState<DeadlineResolution>('completed');
const [note, setNote] = useState(''); const [note, setNote] = useState('');
if (!deadline) return null; const def = deadline ? getDeadlineType(deadline.typeId) : undefined;
const def = getDeadlineType(deadline.typeId);
// "intrerupt" option only for avize deadlines that have a chain (interruption mechanism) // "intrerupt" option only for avize deadlines that have a chain (interruption mechanism)
const filteredOptions = useMemo(() => { const filteredOptions = useMemo(() => {
@@ -45,6 +43,8 @@ export function DeadlineResolveDialog({ open, deadline, onOpenChange, onResolve
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, [def?.chainNextTypeId, def?.category]); }, [def?.chainNextTypeId, def?.category]);
if (!deadline) return null;
// Chain fires on completed, aprobat-tacit, or intrerupt (for avize interruption) // Chain fires on completed, aprobat-tacit, or intrerupt (for avize interruption)
const hasChain = def?.chainNextTypeId && ( const hasChain = def?.chainNextTypeId && (
resolution === 'completed' || resolution === 'aprobat-tacit' || resolution === 'intrerupt' resolution === 'completed' || resolution === 'aprobat-tacit' || resolution === 'intrerupt'